Automatic port for manual tests.#1339
Merged
przemyslaw-zan merged 4 commits intomasterfrom Apr 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
18 tasks
martnpaneq
reviewed
Apr 1, 2026
martnpaneq
reviewed
Apr 1, 2026
martnpaneq
reviewed
Apr 1, 2026
packages/ckeditor5-dev-tests/lib/utils/manual-tests/createserver.js
Outdated
Show resolved
Hide resolved
martnpaneq
approved these changes
Apr 2, 2026
martnpaneq
approved these changes
Apr 2, 2026
Contributor
martnpaneq
left a comment
There was a problem hiding this comment.
We decided to implement a new approach without the need of creating a .port file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🚀 Summary
The manual test server (createserver.js) now automatically finds a free port at startup. When the preferred port (default 8125) is already in use, it tries subsequent ports via recursive
tryListenOnPortuntil a free one is found, withserver.close()on each failed attempt to release the handle. The--portCLI option sets the starting port. Tests cover port retry onEADDRINUSE, rejection on other errors, and all existing behavior updated to use asyncserver.listenwith callbacks.📌 Related issues
💡 Additional information
Testing: Block the port 8125 with any server, then launch manual tests. They should start at 8126.